Bumps in garden: use ign-common5, ign-math7 #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
chapulina
added
the
needs upstream release
scpeters
changed the title
scpeters
reviewed
Dec 29, 2021
| @@ -63,7 +63,7 @@ depth camera to a memory reserved in a globally scoped `Image`. | |||
|
|
|||
| \snippet examples/depth_camera/GlutWindow.cc convert depth to image | |||
|
|
|||
| The other option is the [ConnectNewRgbPointCloud](https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering6/include/ignition/rendering/DepthCamera.hh#L58) call that receives colored point cloud data on callback. | |||
| The other option is the [ConnectNewRgbPointCloud](https://github.com/ignitionrobotics/ign-rendering/blob/ign-rendering7/include/ignition/rendering/DepthCamera.hh#L58) call that receives colored point cloud data on callback. | |||
There was a problem hiding this comment.
this link does not exist yet. I forget what is the preferred approach for branch names in tutorial code links
There was a problem hiding this comment.
We have a mix right now. It's not too bad to have broken links on main because the tutorials aren't published anywhere yet. I don't have a strong preference, but it would be nice to be consistent across all libraries
Codecov Report
@@ Coverage Diff @@
## main #525 +/- ##
==========================================
+ Coverage 54.05% 54.06% +0.01%
==========================================
Files 203 203
Lines 20287 20281 -6
==========================================
- Hits 10966 10965 -1
+ Misses 9321 9316 -5
Continue to review full report at Codecov.
|
|
CI is all 🟢, and I assume @scpeters has already taken a high-level look at this. We can address the tutorial comment later, it would be good to do a sweep over all libraries and document what to do in the future. I'll merge this and its infrastructure PRs to unblock downstream PRs, and then trigger a nightly.
|
chapulina
removed
the
needs upstream release
srmainwaring
added a commit
to srmainwaring/ardupilot_gazebo-1
that referenced
this pull request
Jan 19, 2022
Remove deprecated include: - gazebosim/gz-rendering#525 Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring
added a commit
to srmainwaring/ardupilot_gazebo-1
that referenced
this pull request
Feb 2, 2022
Remove deprecated include: - gazebosim/gz-rendering#525 Signed-off-by: Rhys Mainwaring <[email protected]>
srmainwaring
added a commit
to srmainwaring/ardupilot_gazebo-1
that referenced
this pull request
Mar 28, 2022
Remove deprecated include: - gazebosim/gz-rendering#525 Signed-off-by: Rhys Mainwaring <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gazebo-tooling/release-tools#574